Cover the live L2 path against a real server - #241
Merged
Conversation
Coverage reported eight lines missing in detector_eval: the --l2 branch and the block that writes a recording. They are the only branches of the command that talk to a model, so nothing reached them, and mocking them would have verified a stand-in for the code rather than the code. A socket that speaks ollama's shape reaches them instead. The flag, the recording wrapper, the default transport and the file written all run as they do live, and the test asserts the property the committed artifact's gate depends on: the live run, the bytes it wrote and a replayed run agree. That required the address to become an option, which is not a concession to the test. ollama does not have to sit on this host, and hard-coding that it does was a defect the missing coverage happened to surface.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage reported eight lines missing in detector_eval: the --l2 branch and the block that writes a recording. They are the only branches of the command that talk to a model, so nothing reached them, and mocking them would have verified a stand-in for the code rather than the code.
A socket that speaks ollama's shape reaches them instead. The flag, the recording wrapper, the default transport and the file written all run as they do live, and the test asserts the property the committed artifact's gate depends on: the live run, the bytes it wrote and a replayed run agree.
That required the address to become an option, which is not a concession to the test. ollama does not have to sit on this host, and hard-coding that it does was a defect the missing coverage happened to surface.
What this changes
How it was measured
Checklist
ruff format --check cyberai/ tests/andruff check cyberai/ tests/passpytest -W ignore::DeprecationWarning -m "not slow and not smoke"passes